Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Some validation paths lose established error messages, and release-date validation still accepts invalid calendar dates.
Review effort: Balanced
Findings: 3
Open (3)
Resolved since last review (8)
Files not reviewed (11)
- apps/duckguessr/api/pnpm-lock.yaml: Generated file
- apps/duckguessr/pnpm-lock.yaml: Generated file
- apps/dumili/api/pnpm-lock.yaml: Generated file
- apps/dumili/pnpm-lock.yaml: Generated file
- apps/edgecreator/api/pnpm-lock.yaml: Generated file
- apps/edgecreator/pnpm-lock.yaml: Generated file
- apps/inducksql/pnpm-lock.yaml: Generated file
- apps/web/pnpm-lock.yaml: Generated file
- apps/whattheduck/pnpm-lock.yaml: Generated file
- packages/api/pnpm-lock.yaml: Generated file
- packages/prisma-schemas/pnpm-lock.yaml: Generated file
Comment on lines
+1150
to
+1153
| v.check( | ||
| ({ releaseDate }) => | ||
| !releaseDate || !Number.isNaN(new Date(releaseDate).getTime()), | ||
| "Invalid release date" as const, |
Comment on lines
+38
to
+42
| getIssueDetails: ev( | ||
| v.config(v.pipe(v.string(), v.nonEmpty()), { | ||
| message: "Invalid issuecode", | ||
| }), | ||
| )(async (issuecode) => { |
Comment on lines
+28
to
+32
| sendNewEdgePhotoEmail: ev( | ||
| v.config(v.pipe(v.string(), v.nonEmpty()), { | ||
| message: "Invalid issuecode", | ||
| }), | ||
| )(async (issuecode: string) => { |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.