Skip to content

Bump duckdb and fix connect#489

Merged
staticlibs merged 5 commits into
duckdb:mainfrom
carlopi:bump_duckdb_and_fix_connect
Jun 25, 2026
Merged

Bump duckdb and fix connect#489
staticlibs merged 5 commits into
duckdb:mainfrom
carlopi:bump_duckdb_and_fix_connect

Conversation

@carlopi

@carlopi carlopi commented Jun 23, 2026

Copy link
Copy Markdown
Member

No description provided.

@staticlibs

Copy link
Copy Markdown
Member

Looks good to me! Curiously, I was adding a similar change to mysql_query at this exact time.

@carlopi

carlopi commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

I was trying:

ATTACH 'host=database-1-instance-1.XXX.rds.amazonaws.com port=5432 dbname=postgres user=postgres sslmode=require password=' || getenv('DB_TOKEN') AS aurora (TYPE postgres);
CONNECT aurora EXECUTE CREATE USER myuser WITH PASSWORD 'secret';

and got hit by "No fields returned by query"

@staticlibs

Copy link
Copy Markdown
Member

Yep, the same thing happens with RemoteExecute pushdowns. Unlike ODBC scanner, where odbc_query is used for DML too, in other scanners *_query and *_execute functions are historically separate. I think it makes perfect sense to make *_query functions to return Success:BOOL on DML and to make *_execute functions to be pure aliases to them.

@carlopi carlopi force-pushed the bump_duckdb_and_fix_connect branch from 1376853 to 5d9f172 Compare June 23, 2026 13:51
@carlopi carlopi force-pushed the bump_duckdb_and_fix_connect branch from 5d9f172 to 5d74fbe Compare June 23, 2026 14:02
@carlopi

carlopi commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

This should now be ready

@staticlibs staticlibs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge as convenient!

Support for DML also works in mysql_query now, just the impl/logic is slightly different - going to make the output and behaviour consistent between the scanners.

@staticlibs staticlibs merged commit 5ab5e64 into duckdb:main Jun 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants