Repository navigation
fix(worker): retain Modal app and profile in motion receipts - #126
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reconstruction recovery was directed at the wrong Modal profile because its durable receipt did not record the launching app or credential alias. Save
appIdand the SDK-selectedmodalProfilebefore submission, then preserve them with the function-call ID through every result/cancellation path. Environment credential overrides leave the profile unknown; a local profile alias is never presented as proof of workspace ownership.Existing receipts still prevent resubmission. Metadata is not forwarded as inference arguments. No models, resources, retries or quality gates change; unbounded invocation behavior is unchanged. This does not retroactively repair historical receipts or establish scene quality.
Validation: 255 offline tests covering receipt persistence, actual CLI profile precedence, environment override ambiguity, legacy no-resubmission, resource registration and paid-stage identity; Ruff, repository formatting and diff checks passed. Implemented and tested in an isolated worktree while a separate bounded city recovery runs on unchanged main.