[Breaking]: Drop gateway-based routers - #4097
Merged
Merged
Conversation
Drop the top-level `router` property from gateway and run configurations, deprecated in favor of replica-based routers since 0.20.17. New services and gateways with this configuration property will not be accepted. The behavior of existing services and gateways using this property is undefined. Users are advised to terminate such services and gateways (if any) prior to upgrading `dstack`. Some router implementation details still remain on the gateway and can be removed separately anytime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the top-level
routerproperty from gatewayand run configurations, deprecated in favor of
replica-based routers since 0.20.17. New services
and gateways with this configuration property will
not be accepted. The behavior of existing services
and gateways using this property is undefined.
Users are advised to terminate such services and
gateways (if any) prior to upgrading
dstack.Some router implementation details still remain on
the gateway and can be removed separately anytime.