Skip to content

Force rich non-terminal output in tests #4081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r4victor merged 1 commit into from
Aug 4, 2026
+5 −13
Merged

Force rich non-terminal output in tests #4081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,10 @@ markers = [
"dockerized",
]
env = [
"DSTACK_CLI_RICH_FORCE_TERMINAL=0",
"DSTACK_SSHPROXY_API_TOKEN=test-token",
# Pin every rich console in the process to non-terminal output so tests asserting on plain CLI
# text never see ANSI escapes.
"TTY_COMPATIBLE=0",
]
filterwarnings = [
# Fail on any use of a pydantic v1 shim (`.dict()`, `parse_obj_as`, class-based `Config`, ...)
Expand Down
11 changes: 2 additions & 9 deletions src/dstack/_internal/cli/utils/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,9 @@
"code": "bold sea_green3",
}

console = Console(
theme=Theme(_colors),
force_terminal=settings.CLI_RICH_FORCE_TERMINAL,
)
console = Console(theme=Theme(_colors))

error_console = Console(
theme=Theme(_colors),
force_terminal=settings.CLI_RICH_FORCE_TERMINAL,
stderr=True,
)
error_console = Console(theme=Theme(_colors), stderr=True)


LIVE_TABLE_REFRESH_RATE_PER_SEC = 1
Expand Down
3 changes: 0 additions & 3 deletions src/dstack/_internal/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import os

from dstack import version
from dstack._internal.utils.env import environ
from dstack._internal.utils.version import parse_version

DSTACK_VERSION = os.getenv("DSTACK_VERSION", version.__version__)
Expand Down Expand Up @@ -33,8 +32,6 @@

CLI_LOG_LEVEL = os.getenv("DSTACK_CLI_LOG_LEVEL", "INFO").upper()
CLI_FILE_LOG_LEVEL = os.getenv("DSTACK_CLI_FILE_LOG_LEVEL", "DEBUG").upper()
# Can be used to disable control characters (e.g. for testing).
CLI_RICH_FORCE_TERMINAL = environ.get_bool("DSTACK_CLI_RICH_FORCE_TERMINAL")


class FeatureFlags:
Expand Down
Loading