Fix train.py CLI defaults, optional Piper, and validation batch size - #351
Open
zain1806481 wants to merge 1 commit into
Open
zain1806481 wants to merge 1 commit into
zain1806481 wants to merge 1 commit into
Conversation
store_true flags used the truthy string "False" as default. Make Piper import optional when no sample generator path is configured. Cap validation DataLoader batch size so large feature sets do not OOM on small GPUs.
Author
|
Week submission index: https://github.com/zain1806481/upstream-week-2026-09-14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default="False"onstore_trueCLI flags withdefault=False(the string is truthy).piper_sample_generator_pathis set.DataLoaderbatch size at 256 to avoid loading the entire validation set onto small GPUs at once.Context
Hit while training on a 2 GB Pascal GPU. Validation previously used
batch_size=len(X_val_fp_labels), which could request multiple GB of feature windows in one step.Test plan
python -m openwakeword.train --helpshows flags defaulting offpiper_sample_generator_pathgets past import when not generating clipsMade with Cursor