Skip to content

Updated ffiles - #443

Open
Malcolm-Wander wants to merge 2 commits into
drydocs:mainfrom
Malcolm-Wander:trew
Open

Updated ffiles#443
Malcolm-Wander wants to merge 2 commits into
drydocs:mainfrom
Malcolm-Wander:trew

Conversation

@Malcolm-Wander

Copy link
Copy Markdown

Summary

Closed #428

Test plan

  • pnpm lint && pnpm typecheck && pnpm test pass locally
  • [ ]

Closes #

Changes made
Changes made
@vercel

vercel Bot commented Jul 26, 2026

Copy link
Copy Markdown

@Malcolm-Wander is attempting to deploy a commit to the Collins' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jul 26, 2026

Copy link
Copy Markdown

@Malcolm-Wander Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@collinsezedike collinsezedike left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things before this can move forward.

First, CI: both PR Title and Commit Messages fail, same as your other PR. Please read CONTRIBUTING.md's "Commit Message Convention" and "Title format" sections and fix both, something like fix(web): add aria-live region to Toasts.

Second, this PR's diff includes the blend-adapter reinitialization test from #442 as well as the Toasts change, since this branch was cut from that unmerged commit rather than fresh off main. Please open a fresh branch off main with just the Toasts change, so this PR only closes #428. #442 will get merged separately for #429.

The Toasts implementation itself is well done, keeping the live region mounted at all times rather than only when toasts exist is the right call, and differentiating error announcements with role="alert"/aria-live="assertive" is a nice touch.

Please also fill in the PR body's ## Summary and ## Test plan sections properly, and reference #428 in the Closes # field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] Add aria-live region to Toasts for screen reader announcements

2 participants