Updated ffiles - #443
Conversation
Changes made
Changes made
|
@Malcolm-Wander is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Malcolm-Wander Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
collinsezedike
left a comment
There was a problem hiding this comment.
Two things before this can move forward.
First, CI: both PR Title and Commit Messages fail, same as your other PR. Please read CONTRIBUTING.md's "Commit Message Convention" and "Title format" sections and fix both, something like fix(web): add aria-live region to Toasts.
Second, this PR's diff includes the blend-adapter reinitialization test from #442 as well as the Toasts change, since this branch was cut from that unmerged commit rather than fresh off main. Please open a fresh branch off main with just the Toasts change, so this PR only closes #428. #442 will get merged separately for #429.
The Toasts implementation itself is well done, keeping the live region mounted at all times rather than only when toasts exist is the right call, and differentiating error announcements with role="alert"/aria-live="assertive" is a nice touch.
Please also fill in the PR body's ## Summary and ## Test plan sections properly, and reference #428 in the Closes # field.
Summary
Closed #428
Test plan
pnpm lint && pnpm typecheck && pnpm testpass locallyCloses #