Skip to content

feat(meridian): chore-replace-panic-with-typed-errors-in-router- - #435

Open
Caneryy wants to merge 1 commit into
drydocs:mainfrom
Caneryy:feat/issue-433
Open

feat(meridian): chore-replace-panic-with-typed-errors-in-router-#435
Caneryy wants to merge 1 commit into
drydocs:mainfrom
Caneryy:feat/issue-433

Conversation

@Caneryy

@Caneryy Caneryy commented Jul 25, 2026

Copy link
Copy Markdown

Closes #433

Summary

  • [Chore] Replace panic! with typed errors in router and adapter contracts

Test plan

  • Relevant tests pass locally
  • Manual verification on affected UI or API paths

@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown

@Caneryy is attempting to deploy a commit to the Collins' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jul 25, 2026

Copy link
Copy Markdown

@Caneryy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@collinsezedike collinsezedike left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing on two things:

  1. Commit Messages: header is 73 characters, over the 72-char limit. Needs shortening, e.g. chore(contracts): replace panic! with typed errors.
  2. Soroban Contract Tests: cargo fmt --all -- --check fails on the import block in blend-adapter/src/lib.rs. Run cargo fmt and push the result.

The PR title (feat(meridian): chore-replace-panic-with-typed-errors-in-router-) also needs fixing to match, since this repo squash-merges using the PR title as the commit message.

The implementation itself is correct, I ran the full test suite and clippy locally and both pass clean. Just these two fixed before merge.

@collinsezedike

collinsezedike commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

This PR's body doesn't follow CONTRIBUTING.md's PR body format (see "Pull Request Process" > "PR body format").

The Summary section should describe what changed and why, not restate the issue title. The Test plan checkboxes should be checked once you've actually run pnpm lint && pnpm typecheck && pnpm test locally, and the second line should say what you manually verified, not generic placeholder text.

Please update the PR body to reflect what you actually did and verified before this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore] Replace panic! with typed errors in router and adapter contracts

2 participants