[#2153] Moved environment type detection to 'drevops/environment-detector' and flattened settings includes.#2690
Open
AlexSkrypnyk wants to merge 4 commits into
Open
[#2153] Moved environment type detection to 'drevops/environment-detector' and flattened settings includes.#2690AlexSkrypnyk wants to merge 4 commits into
AlexSkrypnyk wants to merge 4 commits into
Conversation
…ctor' and flattened settings includes.
|
Warning Review limit reached
More reviews will be available in 17 minutes and 30 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (291)
📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…hosting-agnostic.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #2690 +/- ##
==========================================
- Coverage 87.54% 87.47% -0.08%
==========================================
Files 99 99
Lines 5068 5070 +2
Branches 3 3
==========================================
- Hits 4437 4435 -2
- Misses 631 635 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a37ad59f20a822abcdb64df--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
AlexSkrypnyk
added
the
Needs review
github-actions
Bot
added
CONFLICT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2153
Summary
Replaces Vortex's inline environment-type detection logic with
drevops/environment-detector(^0.5), called viaEnvironment::init()insettings.phpwith an override callback that maps the package's canonical types to Vortex's exactlocal/ci/dev/stage/prodconstants. TheENVIRONMENT_*constants are kept as the project-facing API. Lagoon's production-branch detection is preserved via aVORTEX_LAGOON_PRODUCTION_BRANCH->ENVIRONMENT_PRODUCTION_BRANCHbridge, and Acquia's environment-slot mapping is preserved in the override. A local patch (patches/environment-detector-provider-precedence.patch) is applied viacweagans/composer-patchesto give hosting/CI providers precedence over the Docker provider, which is active in every container; the patch should be removed once drevops/environment-detector#74 is resolved upstream.The
includes/directory is also flattened: the two-levelincludes/{providers,modules}/hierarchy collapses to a singleincludes/glob, the two detection-only CI files (settings.circleci.php,settings.gha.php) are deleted, andsettings.acquia.php/settings.lagoon.phpare trimmed to platform settings only.settings.phpnow uses a singleincludes/settings.*.phpglob instead of two separate loops.Changes
Environment::init()replaces ~50 lines of inline detection insettings.php;contextualize: falseprevents the package from double-applying platform settings that Vortex manages in its own include files.includes/{providers,modules}/toincludes/;settings.circleci.phpandsettings.gha.phpdeleted;settings.acquia.phpandsettings.lagoon.phpstripped of detection logic.CiProvider,HostingProvider,Services,Modules, andHostingProjectNamehandlers repointed to the flat include paths;EnvironmentSettingsTestCI cases updated to useCIRCLECI/GITHUB_WORKFLOWenv vars;SettingsTestCaseresets the detector between tests; four docs pages updated; installer fixtures regenerated.patches/environment-detector-provider-precedence.patchadds provider precedence so the Docker provider yields to a more specific hosting/CI provider; required until the upstream fix is published.Before / After