Repository navigation
Update Python bindings to drasi-lib 0.9.3 - #3
Merged
Merged
Conversation
Pins must match published plugins on major.minor, so this takes the 0.9.3-compatible crate set rather than a free bump. Durable reactions now require a persistent index store, and reactions registered before start() wait until deferred queries are running. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Reactions added while running can fail after restart when they depend on binding-managed deferred queries.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates Python bindings for drasi-lib 0.9.3 and adapts durable-reaction lifecycle and storage behavior.
Changes:
- Updates Drasi crate, SDK, plugin, and store versions.
- Adds persistent-index validation and deferred reaction startup.
- Updates tests, CI, examples, and documentation.
| File | Description |
|---|---|
Cargo.toml |
Pins compatible crate versions. |
Cargo.lock |
Locks updated dependency graph. |
src/lib.rs |
Updates reported host versions. |
src/stores.rs |
Detects configured persistent indexes. |
src/errors.rs |
Adds the missing-index error code. |
src/engine.rs |
Validates durability and defers reactions. |
src/components.rs |
Propagates recovery and bootstrap behavior. |
tests/unit/test_registry_pins.py |
Updates expected pins. |
tests/e2e/test_lifecycle.py |
Generalizes lifecycle documentation. |
tests/e2e/test_durable_and_config.py |
Tests persistent-index requirements. |
tests/e2e/test_concurrency.py |
Enables durable concurrency testing with RocksDB. |
.github/workflows/ci.yml |
Runs hermetic tests with RocksDB. |
scripts/build_plugins.py |
Updates local plugin versions. |
README.md |
Documents durable store configuration. |
examples/README.md |
Updates example versions and output. |
docs/plugins.md |
Updates plugin examples and host metadata. |
website/content/docs/guides/python-reactions.md |
Documents durable recovery semantics. |
website/content/docs/guides/plugins.md |
Updates plugin compatibility details. |
website/content/docs/guides/error-handling.md |
Documents the new error code. |
website/content/docs/concepts/_index.md |
Explains durable index requirements. |
CHANGELOG.md |
Records compatibility and behavior changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+204
to
+205
| async fn hold_reaction_until_queries(&self, auto_start: bool) -> bool { | ||
| auto_start && !self.core.is_running().await |
danielgerlag
marked this pull request as ready for review
October 1, 2026 21:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python host was pinned to drasi-lib 0.8.9. Published plugins are version-matched on major.minor, so the bindings need the latest compatible published set to load current plugins.
This takes the 0.9.3-compatible crate set and adapts the host to two behavior changes in that release:
DURABLE_REQUIRES_INDEX_STORE.start()are held and started after deferred queries. drasi-lib 0.9 will not subscribe to a stopped query.auto_resetis accepted by reporting snapshot capability only for that policy. Bootstrap is still a no-op, so the current result set is not replayed to the callback.Reaction::bootstrapdoes not replay the current result set forauto_reset. It only satisfies the engine flag. A real snapshot replay would be a follow-up.