Conversation
…e state root A tmux server is long-lived, and its panes inherit the environment it was started with. A server cold-started under BMAD_LOOP_STATE_DIR=S1, then reused by a launch under S2, hands S1 to the parked engine window and every window-0 shell. The engine then writes its control plane where the launcher never looks, and the live run reads as gone (bmad-code-org#731). This is the interim from the bmad-code-org#731 design: detect it and say so; carrying the root explicitly is a later change. - TerminalMultiplexer.inherited_env(session, name, *, on_fault=None) is a new non-abstract query answering what a new pane will inherit: None (unknown, the seam default), the UNSET sentinel (known absent), or the value ("" included). It never raises; a failed query reports through on_fault instead of folding into unknown. - TmuxMultiplexer implements it with show-environment -t =S NAME, plus the -g fallback on an exact "unknown variable" miss. It sits on TmuxMultiplexer, not BaseTmuxBackend, so psmux keeps "unknown": its show-environment cannot see inherited values. - runs.state_root is now runs.resolve_state_root(os.environ, passwd_home), byte-identical over 2560 env combinations on Windows and Linux. The passwd home is looked up lazily and used only when HOME is absent: absent and empty HOME are different inputs. - _ensure_ctl_session compares the root a new pane would resolve with the launcher's own, after both the create and the reuse arm, and warns once per process through the TUI with a shell-quoted remedy. Unknown answers are silent, faults are reported, and the launch is never blocked. Out-of-tree backends written against today's seam are unaffected: a StubMux implementing only the released abstract set completes both arms with no warning. Known gaps: - Windows test_runs has 4 environmental symlink WinError 1314 failures. - WSL ran the 6 touched test files only (1586 passed). The rest of the Linux suite is unverified locally. - trunk check could not run locally (a broken ruff plugin); ruff, prettier and pyright were run directly. Refs bmad-code-org#731
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…set-environment On tmux, bmad-loop-ctl is one session shared by every bmad-loop project on that server, so the stale-state-root remedy re-roots new windows for all of them. The warning and the docs now say so, offer set-environment only where no other project uses another state root, and say that kill-server ends every session on the server, live runs included. Tests cover the shared-server wording and a set-empty inherited override, which stays silent; the cascade spec gains empty-override rows; two redundant force_tmux_backend marks are dropped. Refs bmad-code-org#731
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review mirror of bmad-code-org#854 for Codex review. Not for merge here.
The interim for bmad-code-org#731: detect a reused tmux server that would plant a stale
BMAD_LOOP_STATE_DIRin new panes, and say so. This is Stage 1 of the design in bmad-code-org#850. Carrying the root explicitly in the parked window's argv is Stage 2, a separate change.Problem
A tmux server is long-lived, and its panes inherit the environment it was started with. A server cold-started under
BMAD_LOOP_STATE_DIR=S1, then reused by a launch under S2, hands S1 to the parked engine window and every window-0 shell. The engine writes its control plane where the launcher never looks, and the live run reads as gone.Change
TerminalMultiplexer.inherited_env(session, name, *, on_fault=None): a new non-abstract query for what a new pane will inherit. It answersNone(unknown, the seam default), theUNSETsentinel (known absent), or the value,""included. It never raises; a query that was attempted and failed reports throughon_faultrather than folding into "unknown".TmuxMultiplexer, notBaseTmuxBackend. It runsshow-environment -t =S NAME, plus a-gfallback on an exactunknown variablemiss. Reply shapes were measured on tmux 3.4:NAME=v,NAME=, the-NAMEremoval marker, misses, and a missing session.show-environmentshows onlyPSMUX*/TMUX*names, so it cannot see an inheritedBMAD_LOOP_STATE_DIR; the per-project registry already closes the ordinary path there.runs.resolve_state_root(env, passwd_home): the state-root cascade as a pure function.runs.state_root()delegates to it and is byte-identical: a differential over 2560 env combinations on both Windows and Linux found 0 mismatches. The passwd home is looked up lazily and only used whenHOMEis absent, because absent and emptyHOMEare different inputs._ensure_ctl_session: after both the create and the reuse arm, it compares the root a new pane would resolve with the launcher's own. On a mismatch it warns once per process through the TUI, naming both roots and giving a shell-quoted remedy.docs/multiplexer-backends.md: a new subsection with the operator remedy. CHANGELOGFixed.Compatibility
A
StubMuxthat implements only the released abstract set completes both_ensure_ctl_sessionarms with no warning and no error. Out-of-tree backends need no change.Tests
11 gates were ablated, each confirmed to fail its test without the gate. These include: the fault path, placing the implementation on the base class (psmux test), passwd use on an empty
HOME, eager passwd lookup, a raw-override comparison instead of resolved roots, the looseunknown variablematch, and the remedy quoting.Local results
test_runs, all environmental symlinkWinError 1314.Refs bmad-code-org#731 bmad-code-org#850
Summary by CodeRabbit