Repository navigation
fix: deduplicate Apple libraries in the Start9 builder - #1
Closed
helix-white wants to merge 2 commits into
Closed
helix-white wants to merge 2 commits into
helix-white wants to merge 2 commits into
Conversation
…rust-cross#464) Zig's self-hosted Mach-O linker (since 0.14) emits one LC_LOAD_DYLIB load command per -l flag instead of deduplicating like ld64 does. When multiple crates declare the same native library (e.g. two crates each emitting cargo:rustc-link-lib=objc), the resulting binary contains duplicate linked dylib entries, which newer macOS dyld refuses to load: Termination Reason: Namespace DYLD, Code 0, duplicate linked dylib '/usr/lib/libobjc.A.dylib' Deduplicate repeated -l arguments (keeping the first occurrence) for Apple targets in both the response-file and direct-args linker paths. This matches ld64 behavior, which warns and ignores duplicates. Fixes rust-cross#457 Claude-Session: https://claude.ai/code/session_012W2Vg9xdxKaD8sEE2HiUQb Co-authored-by: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 58c6443) Helix-Harness: pi Helix-Model: openai-codex/gpt-6.1-sol
Helix-Harness: pi Helix-Model: openai-codex/gpt-6.1-sol
This was referenced Oct 23, 2026
Author
|
Superseded by Start9Labs/start-technologies#4377. The replacement layers a checksum-pinned upstream cargo-zigbuild 0.24.0 rebuild and a one-line RVA23 patch onto the existing pinned image, with native image verification and GHCR publishing in the monorepo. No repository fork transfer is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport rust-cross#464 (58c6443), deduplicating Apple
-larguments in direct and response-file linking while preserving Linux library repetition. Retains Start9's compiler patches and Rust/Zig versions instead of merging upstream's unrelated refactor. Addresses the builder-side cause of Start9Labs/start-technologies#4372.Version the backport
0.23.0-start9.1, givingpublish.sha distinct image tag. Extend tests for both macOS architectures and response-file rewriting; run library unit tests in CI, which previously built the test fixtures without executing the unit suite. Shorten the imported helper comment.Verified: 35 library unit tests; Rust formatting; all-target/all-feature Clippy. Using the existing Start9 image's Zig 0.16.0 and macOS SDK, linked real arm64 and x86_64 Mach-O executables through both argument paths: the old tool emits two libobjc load commands, the patched tool emits one with no duplicate dylibs. Full multi-platform image publication and start-cli rebuilds have not been performed.
Helix-Harness: pi
Helix-Model: openai-codex/gpt-6.1-sol