Repository navigation
fix(provenance): start the managed webhook server - #20
Merged
Merged
Conversation
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provider provenance webhook stays unready because its configured server is never added to the controller-runtime manager. The health probe starts, but the TLS listener does not, leaving readiness reporting
webhook server has not been started yet.Register the admission handler through
mgr.GetWebhookServer()so the manager starts and stops the configured TLS server. Keep the existing validation, certificate configuration and readiness check.