Repository navigation
fix(helm): keep remote consumers off artifact PVCs - #18
Merged
Merged
Conversation
A Liqo consumer can use a workload claim bound to a virtual node. Mounting that claim in the Snapshot operator ties the metadata controller's scheduling to the provider instead of keeping it on the consumer cluster. Add operator.mountArtifactPVC for remote-only consumers. When disabled, the operator uses a bounded scratch directory while provider agents retain artifact access. Require consumer provenance and a disabled local agent, and preserve the PVC mount for native and mixed installations. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
A Liqo consumer can bind its workload artifact PVC to a provider virtual node. The Snapshot operator currently mounts that claim too, preventing it from remaining on the consumer cluster.
Add operator.mountArtifactPVC, defaulting to true. Remote-only consumers can disable the mount and use a bounded scratch directory while provider agents retain artifact access. Disabling the mount requires consumer provenance, remote cleanup delegation and a disabled local agent.
Which issue(s) this PR fixes:
No issue linked yet. The fork has issues disabled; keep this PR in draft until the issue-reference requirement is resolved.
How was this tested?
Live GPU capture and restore were not tested.
Special notes for your reviewer:
Native and mixed installations retain the existing PVC mount. Clusters with existing native Snapshot content must also retain it.
This fixes a prerequisite for doublewordai/internal#4904. It adds an optional Helm value without changing CRD or Go APIs.
Does this PR introduce an API change?
NONE
Additional documentation, e.g. enhancement proposals, usage docs:
docs/operations/liqo-control-plane.md
Checklist