Skip to content

refactor(runtime): serve /live and /health from separate handlers - #6

Closed
sejori wants to merge 1 commit into
mainfrom
validation-gates-v2/1-health-split
Closed

sejori wants to merge 1 commit into
mainfrom
validation-gates-v2/1-health-split

Conversation

@sejori

@sejori sejori commented Oct 12, 2026 •

Copy link
Copy Markdown

Part 1 of 6 of the worker validation gates stack (DEP ai-dynamo/dynamo#15897). Replaces #1, unchanged.

Summary

/live gets its own handler. It returns the same body as /health today, so behaviour doesn't change; later PRs can then hold /health (readiness) without restarting the worker through /live.

Validation

test_live_and_health_agree: both endpoints return the same status and body for the ready and notready starting states.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

/live and /health share one handler today, so nothing can be added to
readiness without also changing liveness. Give /live its own handler.
Both still return the same status and body.

First step of the worker validation gates DEP.

Signed-off-by: Seb Ringrose <seb@doubleword.ai>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.

View guided diff | Turn on auto-fix | Re-trigger cubic

@sejori

sejori commented Oct 15, 2026

Copy link
Copy Markdown
Author

Superseded by ai-dynamo#16524 (prep) and ai-dynamo#16525 (gates), which carry this series rebased on current upstream main, including the per-gate phase that replaces DYN_WORKER_VALIDATION_HOLD (see DEP ai-dynamo#15897). Closing so there's one copy to maintain.

@sejori sejori closed this Oct 15, 2026

This branch had an error being deployed

1 failed deployment
external_collaborator — 327813a8 Deployed Oct 12, 2026 by sejori via ok-to-test #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant