Repository navigation
Conversation
/live and /health share one handler today, so nothing can be added to readiness without also changing liveness. Give /live its own handler. Both still return the same status and body. First step of the worker validation gates DEP. Signed-off-by: Seb Ringrose <seb@doubleword.ai>
sejori
had a problem deploying
to
external_collaborator
October 12, 2026 15:08 — with
GitHub Actions
Failure
This was referenced Oct 12, 2026
There was a problem hiding this comment.
No issues found across 1 file
Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.
View guided diff | Turn on auto-fix | Re-trigger cubic
Author
|
Superseded by ai-dynamo#16524 (prep) and ai-dynamo#16525 (gates), which carry this series rebased on current upstream |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of 6 of the worker validation gates stack (DEP
ai-dynamo/dynamo#15897). Replaces #1, unchanged.Summary
/livegets its own handler. It returns the same body as/healthtoday, so behaviour doesn't change; later PRs can then hold/health(readiness) without restarting the worker through/live.Validation
test_live_and_health_agree: both endpoints return the same status and body for thereadyandnotreadystarting states.🤖 Generated with Claude Code