Repository navigation
fix(agent): resample stalled synthetic token candidates - #29
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the Rust agent synthetic-text generator against ByteLevel/BPE edge cases where token offsets can’t be used to safely (and strictly) trim text down to an exact token target, preventing repeated attempts from getting “stuck” on an unshrinkable string.
Changes:
- Ensure offset-based trimming only truncates when it will strictly shorten the UTF-8 string (guard
end_offset < text.len()). - When trimming can’t make progress, resample a fresh synthetic token candidate instead of retrying with an equivalent decoded prefix.
- Add a deterministic regression test using a minimal ByteLevel BPE tokenizer to validate exact-token synthesis succeeds for the problematic offset behavior.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
No benchmark or external model traffic was launched.