Skip to content

chore(deps): update dependency node to v24 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency node to v24 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: "22"
node-version: "24"

@doubleword-code doubleword-code Bot May 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: Consider adding a test matrix instead of only testing on Node 24.

Why it matters: The package.json declares support for node >= 18, but CI only validates against Node 24. This means compatibility with Node 18, 20, and 22 is unverified, which could lead to issues for users on LTS versions.

Suggested fix: Add a strategy matrix:

strategy:
  matrix:
    node-version: ["18", "20", "22", "24"]

Or at minimum test on both the oldest supported (18) and latest LTS (22).


- name: Install dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: "22"
node-version: "24"

@doubleword-code doubleword-code Bot May 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: Using Node.js 24 (Current, not LTS) for production builds is risky.

Why it matters: According to the Node.js release schedule, Node 24 won't enter LTS until October 2025. Production applications should use LTS releases for stability. The published npm package will be built with a non-LTS runtime, which could introduce unexpected behavior or incompatibilities.

Node 22 is currently Active LTS and more appropriate for production builds.

Suggested fix: Change to Node 22 (LTS):

node-version: "22"

Alternatively, if Node 24 is intentional, add a comment explaining the rationale.

registry-url: "https://registry.npmjs.org"

# npm trusted publishing (OIDC) needs npm >= 11.5.1; Node 22 ships npm 10.
Expand Down
16 changes: 8 additions & 8 deletions typescript/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"openai": ">=4.104.0 <7"
},
"devDependencies": {
"@types/node": "^22.0.0",
"@types/node": "^24.0.0",
"tsx": "^4.20.6",
"tsdown": "^0.22.2",
"typescript": "^5.7.0"
Expand Down
Loading