Skip to content

[net11.0] [dotnet] Remove workaround for dotnet/sdk#52480#25720

Draft
rolfbjarne wants to merge 1 commit into
net11.0from
rolfbjarne/dev-rolf-remove-sdk-52480-workaround
Draft

[net11.0] [dotnet] Remove workaround for dotnet/sdk#52480#25720
rolfbjarne wants to merge 1 commit into
net11.0from
rolfbjarne/dev-rolf-remove-sdk-52480-workaround

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

The _LinkReadyToRunMachO target override was added as a temporary workaround to skip the built-in dylib creation until dotnet/sdk#52480 was merged.

That PR has now been merged, so the workaround is no longer needed.

🤖 Pull request created by Copilot

The workaround overrode the _LinkReadyToRunMachO target to skip
the built-in dylib creation. Now that dotnet/sdk#52480 has been
merged, this is no longer needed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@rolfbjarne rolfbjarne changed the base branch from main to net11.0 June 17, 2026 17:10
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [CI Build #d43652b] Build passed (Build packages) ✅

Pipeline on Agent
Hash: d43652b8829b9e4e3adf1b2085a3c9e3b32aad9e [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [CI Build #d43652b] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: d43652b8829b9e4e3adf1b2085a3c9e3b32aad9e [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: d43652b8829b9e4e3adf1b2085a3c9e3b32aad9e [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [CI Build #d43652b] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: d43652b8829b9e4e3adf1b2085a3c9e3b32aad9e [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🔥 [CI Build #d43652b] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 17 tests failed, 178 tests passed.

Failures

❌ introspection tests

1 tests failed, 8 tests passed.

Failed tests

  • introspection/macOS/Debug: Failed (Test run failed.
    Tests run: 34 Passed: 33 Inconclusive: 0 Failed: 1 Ignored: 0)

Html Report (VSDrops) Download

❌ linker tests (tvOS)

11 tests failed, 0 tests passed.

Failed tests

  • dont link/tvOS - simulator/Debug: LaunchTimedOut
  • dont link/tvOS - simulator/Release: LaunchTimedOut
  • link sdk/tvOS - simulator/Debug: LaunchTimedOut
  • link sdk/tvOS - simulator/Release: LaunchTimedOut
  • link all/tvOS - simulator/Debug: LaunchTimedOut
  • link all/tvOS - simulator/Release: LaunchTimedOut
  • link all/tvOS - simulator/Debug (don't bundle original resources): LaunchTimedOut
  • trimmode copy/tvOS - simulator/Debug: LaunchTimedOut
  • trimmode copy/tvOS - simulator/Release: LaunchTimedOut
  • trimmode link/tvOS - simulator/Debug: LaunchTimedOut
  • trimmode link/tvOS - simulator/Release: LaunchTimedOut

Html Report (VSDrops) Download

❌ xcframework tests

2 tests failed, 2 tests passed.

Failed tests

  • xcframework-test/iOS - simulator/Debug: LaunchTimedOut
  • xcframework-test/tvOS - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

❌ Tests on macOS Sonoma (14) tests

2 tests failed, 3 tests passed.

Failed tests

  • introspection: Failed (exit code 2)
    • CheckFailAttachments : System.NullReferenceException : Object reference not set to an instance of an object.
  • monotouch-test: Failed (exit code 2)
    • No test failure details available. stderr output:
      • Got a SIGABRT while executing native code. This usually indicates
      • a fatal error in the runtime or one of the native libraries
      • used by your application.
      • make[1]: *** [exec-maccatalyst-dotnet-x64-monotouch-test] Error 134
      • sed: ../.git: No such file or directory
      • fatal: not a git repository (or any of the parent directories): .git
      • fatal: not a git repository (or any of the parent directories): .git
      • ../Make.config:216: The required Xcode (26.5) is not installed in /Applications/Xcode_26.5.0.app/Contents/Developer - this directory does not exist. Any parts of the build that require Xcode will be disabled.
      • /bin/sh: ./create-make-config.sh: No such file or directory
      • make: *** [exec-monotouch-test] Error 1

Html Report (VSDrops) Download

❌ Tests on macOS Tahoe (26) tests

1 tests failed, 4 tests passed.

Failed tests

  • introspection: Failed (exit code 2)
    • TypoTest : Typos!
    • Unnecessary allowed typo "Arae" is not present in any API name
    • Unnecessary allowed typo "Mada" is not present in any API name
    • ... and 11 more failures

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 24 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 27 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 24 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: d43652b8829b9e4e3adf1b2085a3c9e3b32aad9e [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants