Skip to content
This repository was archived by the owner on Jun 29, 2020. It is now read-only.
This repository was archived by the owner on Jun 29, 2020. It is now read-only.

Leaking CancellationTokenSource #89

Description

Hi all,

I've played around with the code recently and noticed that CancellationTokenSource instances are created quite often and never disposed.

I understand, that eventually they would be cleared up by GC, but still, it can cause issues under heavy loads as it might create a Timer and ManualResetEvent internally.

So is it a good practice here not to dispose CancellationTokenSource?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions