Skip to content

Add namecraft.owns.it.com - #211

Closed
ksrsing wants to merge 9 commits into
domainsproject:mainfrom
ksrsing:main
Closed

ksrsing wants to merge 9 commits into
domainsproject:mainfrom
ksrsing:main

Conversation

@ksrsing

@ksrsing ksrsing commented Sep 25, 2026

Copy link
Copy Markdown

Requirements

  • [ x] You have completed your website.
  • [ x] The website is reachable.
  • [ x] The CNAME record doesn't contain https:// or /.
  • [x ] There is sufficient information at the owner field.
  • [x ] There is no NS Records (Enforced as of September 4th, 2024)
  • [ x] I fully accept and undestand the Terms of Service outline when using this service.
  • [x ] I understand that if these requirements are not met my pull request will be closed.

Description

NameCraft is a free stylish name generator website.
It generates gaming, cool, royal and other stylish names for users.

Link to Website

https://ksrsing.github.io/stylish-name/

@ksrsing

ksrsing commented Sep 25, 2026

Copy link
Copy Markdown
Author

CLA has passed, but the validation workflow is failing because it uses
pull_request_target with actions/checkout.

The workflow should use pull_request instead, or the maintainer should
securely update the checkout configuration.

Please update the validation workflow and rerun the checks.

@ksrsing ksrsing closed this Sep 25, 2026
@ksrsing ksrsing reopened this Sep 25, 2026
@ksrsing

ksrsing commented Sep 25, 2026

Copy link
Copy Markdown
Author

Hi, CLA is passing.

The Tests job is failing at actions/checkout@v4 because this is a fork PR and the workflow uses pull_request_target.

The test commands are not reached because checkout fails first.

Could you please update the validation workflow to use a safe checkout/trigger setup for fork PRs?

1 similar comment
@ksrsing

ksrsing commented Sep 25, 2026

Copy link
Copy Markdown
Author

Hi, CLA is passing.

The Tests job is failing at actions/checkout@v4 because this is a fork PR and the workflow uses pull_request_target.

The test commands are not reached because checkout fails first.

Could you please update the validation workflow to use a safe checkout/trigger setup for fork PRs?

@ksrsing ksrsing closed this Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant