Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS backend tries to load IOKit from
/System/Library/IOKit.framework/IOKit, which omits theFrameworksdirectory. The failed lookup sendshidapi_IOHIDDeviceGetServicethrough its private OS X 10.5 layout fallback even though the public symbol is available.Use
/System/Library/Frameworks/IOKit.framework/IOKitin both the original C source and the generatedhidapi_mac.hthat Cgo actually includes. Regenerating the header leaves no further changes.On the tested Apple Silicon Mac, upstream HEAD
27ac09aenumerated a blink(1) mk2 with an empty path, preventingDeviceInfo.Open. With both files updated, enumeration returned a nonempty IOKit path and the same exact-serial fixture completed 16/16 sequential firmware Feature Report queries, returning firmware204. No first-device fallback was used.Validation on macOS27.2 arm64, SDK27.2, Go1.27.3 / CGO:
IOHIDDeviceGetService.go test -race -count=1 -timeout=2m ./...andgo vet ./...pass.vcommand/write + fresh-buffer/read transactions; no retries, color, pattern or Flash commands. This hardware result covers the one Mac/mk2 fixture.