Skip to content

Add profile tests#621

Open
alinaliBQ wants to merge 11 commits into
documentdb:mainfrom
alinaliBQ:profile
Open

Add profile tests#621
alinaliBQ wants to merge 11 commits into
documentdb:mainfrom
alinaliBQ:profile

Conversation

@alinaliBQ

@alinaliBQ alinaliBQ commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Add command operator tests for profile. Tests database profile behavior, output collection, syntax, and expected errors. Adds setup to DiagnosticTestCase. no_parallel is used for test cases that se level/rate/filters etc., because these are global settings that can impact other tests.

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jun 17, 2026
@documentdb-triage-tool

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status In Progress
Confidence: 0.85 (mixed)

Reasoning

component from path globs (test-coverage); effort from diff stats (1315+1 LOC, 11 files); LLM: Adds new test coverage for the profile command operator, including setup extensions to DiagnosticTestCase, touching test files within the compatibility tests component.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ alinaliBQ marked this pull request as ready for review June 17, 2026 21:32
@alinaliBQ alinaliBQ requested a review from a team as a code owner June 17, 2026 21:32
SLOWMS_BOUNDARY_TESTS: list[DiagnosticTestCase] = [
DiagnosticTestCase(
"boundary_int32_max",
setup=[{"profile": 0, "slowms": 2_147_483_647}],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to hardcode these INT_MIN and MAX ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to use INT32_MAX and INT32_MIN

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants