Add query and write tests for findAndModify#619
Open
vic-tsang wants to merge 2 commits into
Open
Conversation
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage); effort from diff stats (2854+0 LOC, 11 files); LLM: Adds new query and write compatibility tests for findAndModify, expanding test coverage under documentdb_tests/compatibility/tests/. If a label is wrong, remove it manually and ping |
430998b to
7ea777c
Compare
Signed-off-by: Victor Tsang <vitsangp@amazon.com>
7ea777c to
6559185
Compare
|
nit: test_findAndModify_update_modes.py contains two standalone tests that belong elsewhere:
|
Signed-off-by: Victor Tsang <vitsangp@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Note: I have omitted the following tests as it's already covered in the respective files:
Collation matching, sort, and remove behavior with findAndModify (5 cases)
core/collation/command_level/operations/test_operations_find_and_modify.py(14 cases, superset)Collation missing locale validation error (1 case)
core/collation/command_level/operations/test_operations_find_and_modify.py→validation_missing_localefindAndModify rejected on views
core/collections/views/test_views_write_rejection.py→find_and_modify_rejectedfindAndModify update rejected on timeseries collections
core/collections/timeseries/test_timeseries_updates.py→find_and_modify_update_rejectedfindAndModify update succeeds on capped collections
core/collections/capped_collections/test_capped_collections_write_position.py→test_capped_find_and_modify_position(strongertest that also verifies position preservation)
Ref: