Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# The `main` ruleset requires a code-owner review, so this team's membership is
# the review boundary. The team needs an explicit repo grant (Maintain) or
# GitHub silently ignores it here.
* @docsy/maintainers
11 changes: 10 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ against already-pinned actions. Results upload to the repository's Security tab
as code-scanning alerts.

- The job passes whatever it finds; findings are alerts to triage. Blocking, if
any, would come from a code-scanning rule in a ruleset on `main`.
any, comes from a code-scanning rule in a ruleset on `main`.
- The workflow calls the [OpenTelemetry shared workflow][otel-zizmor] at a
pinned commit; that workflow pins the zizmor action, which pins the zizmor
image by digest, so the scanner moves only when the pin here does. Review the
Expand All @@ -138,6 +138,15 @@ as code-scanning alerts.
- `security-events: write` sits alone in this workflow, away from the job that
installs and builds.

### Merging to `main`

The `main` branch ruleset requires one approving review from a code owner:
`.github/CODEOWNERS` names the `@docsy/maintainers` team for every path, so team
membership is the review boundary, and a workflow's approval never satisfies the
rule. The team holds an explicit Maintain grant on the repo; without one GitHub
silently ignores a CODEOWNERS team. The Maintain role and above can bypass the
review rule (**Bypass rules and merge**, or `gh pr merge --admin`).

[alternate dashboard]: https://app.netlify.com/sites/goldydocs/deploys
[deploys]: https://app.netlify.com/sites/docsy-example/deploys
[Docsy]: https://github.com/google/docsy
Expand Down
Loading