Conversation
ParseCPUs multiplied the ratio by 1e9 and called Int64, which keeps the low 64 bits. 10000000000 CPUs came back as -8446744073709551616 and a nil error. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParseCPUsturns a CPU count into nano-CPUs (n * 1e9) and then callsbig.Int.Int64. That call keeps the low 64 bits.ParseCPUs("10000000000")returned-8446744073709551616and a nil error.9223372036.854775808(2^63 nano-CPUs) came back asmath.MinInt64.Values that fit still parse.
9223372036.854775807ismath.MaxInt64.-9223372036.854775808ismath.MinInt64. One nano-CPU past either end now returnsvalue is out of range.docker run --cpus,docker update --cpus, service CPU limits, and Composecpusall go through this function.Release notes
Drafted with Grok 4.7. The code has not yet been reviewed by a human.