Conversation
Signed-off-by: Conlan Cesar <conlan.cesar@datadoghq.com>
Signed-off-by: Conlan Cesar <conlan.cesar@datadoghq.com>
HeroCC
force-pushed
the
extra-cli-search-dir
branch
from
September 28, 2026 19:54
bd1dbc2 to
1229201
Compare
HeroCC
marked this pull request as ready for review
September 28, 2026 20:30
vvoland
approved these changes
Sep 29, 2026
vvoland
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me!
@thaJeztah WDYT?
Collaborator
|
One nit though - could you please squash these commits into 1? |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional system CLI plugin directory that downstream builds can set with the Go linker
-Xflag. This lets downstream packagers expose package-managed CLI plugins without requiring users to modify their Docker configuration.If accepted, I plan on using this in homebrew's docker formula to avoid needing caveats (like this) for plugins.
Testing
go test github.com/docker/cli/cli-plugins/managergo test -ldflags='-X github.com/docker/cli/cli-plugins/manager.additionalSystemPluginDir=/test/cli-plugins' github.com/docker/cli/cli-plugins/managerRelease notes (optional)
A picture of a cute animal (not mandatory but encouraged)
Rex :)