vendor: tags.cncf.io/container-device-interface v1.1.1 - #7289
Merged
Merged
Conversation
removes some transitive dependencies full diff: cncf-tags/container-device-interface@v1.1.0...v1.1.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
area/dependencies
kind/bugfix
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🟢 Approval recommended
The changes are a straightforward vendored dependency bump with small, clearly-correct parser adjustments and no unresolved issues found in the modified regions.
Pull request overview
This PR updates the vendored tags.cncf.io/container-device-interface dependency to v1.1.1, aligning Docker CLI’s vendored parser logic and vendor metadata with the upstream release (and its reduced transitive dependencies).
Changes:
- Vendor bump of
tags.cncf.io/container-device-interfacefrom v1.1.0 to v1.1.1 (vendor.mod / vendor.sum / vendor/modules.txt). - Parser improvements in the vendored CDI parser: use
strings.Cutfor delimiter parsing and avoid a slice edge-case in vendor/class validation.
File summaries
| File | Description |
|---|---|
| vendor/tags.cncf.io/container-device-interface/pkg/parser/parser.go | Updates parsing helpers to use strings.Cut and fixes an edge-case in vendor/class name validation. |
| vendor/modules.txt | Records the vendored module version bump to v1.1.1 (and upstream go directive metadata). |
| vendor.sum | Updates checksums for the new vendored module version. |
| vendor.mod | Updates the required module version to v1.1.1 for vendoring. |
Review details
- Files reviewed: 2/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
@vvoland ptal |
vvoland
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes some transitive dependencies
full diff: cncf-tags/container-device-interface@v1.1.0...v1.1.1
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)