fix(release): set RELEASED_VERSION env var#7
Merged
Conversation
Both action-extract-release-notes calls omitted this env var, so it throws once release.yml actually runs against a pushed tag. Fixes #6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
release.ymlcallsdnd-mapp/action-extract-release-notestwice (thevalidatejob's "Check changelog section" step, and thecreate-releasejob's "Prepare release notes" step) but never sets theRELEASED_VERSIONenvironment variable that action reads. Since the workflow was added afterv1.0.0was tagged by hand, it has never actually run, so the gap wasn't caught before now: the first real tag push would fail both steps withThe RELEASED_VERSION environment variable is not set.Changes
Added an
env:block scoped to just those two steps, settingRELEASED_VERSION: ${{ github.ref_name }}. Confirmed againstaction-extract-release-notes's own source that it expects exactly this format (the raw pushed tag, e.g.v1.2.3, with thevstripped internally), so no other changes were needed.Test Plan
vX.Y.Ztag and confirmrelease.ymlruns both steps successfully end-to-endFixes: #6