Repository navigation
Fix input validation in identify3d and subscenes - #508
Merged
dmurdoch merged 1 commit intoJul 15, 2026
Merged
Conversation
Owner
|
Thanks, those all look like good fixes. I'll accept after testing... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
length(buttons > 1)should belength(buttons) > 1; as written it is always >= 1 (truthy), so the else-branch is dead and a single-button call prints "the NA button to quit".buttons[1]is a second argument tocat, not togettextf, so even when fixed it would print the literal%s.pmatch,embeddingsis integer;2L == "modify"coerces to"2" == "modify", alwaysFALSE, so the prohibition on a"modify"mouse embedding is never enforced.Found with https://github.com/sims1253/ry :)