Bump smoke-tests to vitest 4 to drop the worker rpc timeout flake - #1059
Merged
Conversation
The ubuntu smoke job on the release PR failed with an unhandled '[vitest-worker]: Timeout calling "onTaskUpdate"' error even though every test passed. vitest 3 gives the worker-to-main rpc a 60s timeout, and the smoke suite blocks the worker with long spawnSync calls (Rust/C#/Java builds) while the main thread is busy with other files, so the reply can arrive after the deadline. vitest 4 disables that timeout entirely (timeout: -1 on the worker rpc), which removes this flake class. vite 8 (pulled in by vitest 4) transforms with oxc, so the old esbuild.tsconfigRaw workaround was ignored and only produced a warning. It is no longer needed: smoke-tests/tsconfig.json stops the tsconfig walk before it reaches the root config that extends @varlock/tsconfig.
Contributor
There was a problem hiding this comment.
Important
The config removal currently prevents the smoke suite from loading on Ubuntu and macOS.
Reviewed changes Reviewed the Vitest 4 dependency upgrade and the associated transform-config cleanup.
- Vitest upgrade: Moves the isolated smoke-test workspace from Vitest 3 to Vitest 4, currently resolving Vitest 4.1.11 with Vite 8.2.2.
- Transform configuration: Removes the previous esbuild-specific
tsconfigRawoverride now that Vite transforms through Oxc.
azure/gpt-5.6-sol | 𝕏
Oxc honours a tsconfig's include set when discovering the config for a file, so helpers/*.ts (not covered by tests/**) walked up to the root tsconfig, whose extends target is not installed in the isolated smoke-test pnpm environment. Widening the include keeps every transformed source on the self-contained smoke-tests config.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the follow-up fix added since the prior Pullfrog review.
- Smoke-test tsconfig coverage: Added the imported helper modules and
vitest.config.tsto the isolated smoke-test config, preventing Oxc from falling through to the unavailable root tsconfig.
azure/gpt-5.6-sol | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
smoke-tests: vitest^3.2.4->^4.0.18(matches the root catalog)esbuild.tsconfigRawblock fromsmoke-tests/vitest.config.tshelpers/**/*.tsandvitest.config.tsto thesmoke-tests/tsconfig.jsoninclude setWhy
The ubuntu smoke job on the release PR failed with an unhandled
[vitest-worker]: Timeout calling "onTaskUpdate"error even though all 168 tests passed (https://github.com/dmno-dev/varlock/actions/runs/33596804177/job/100142117083).vitest 3 gives the worker-to-main rpc a 60s timeout. The smoke suite blocks its worker with long
spawnSynccalls (Rust/C#/Java builds inlang-modules.test.ts) while the main thread is busy with other files, so the reply can arrive after the deadline. vitest 4 sets that rpc timeout to-1, which removes this flake class.vite 8 (pulled in by vitest 4) transforms with oxc, so the old
esbuild.tsconfigRawworkaround was ignored and only produced a "both esbuild and oxc options were set" warning. Oxc discovers the tsconfig per file and honoursinclude, so sources not covered bytests/**(thehelpers/modules) walked up to the root tsconfig, whoseextendstarget is not installed in the isolated smoke-test pnpm environment. Widening the smoke-tests tsconfig include keeps every transformed source on the self-contained config. Verified locally by pointing the rootextendsat a nonexistent package and running the full suite.Full smoke suite passes locally under vitest 4 (17 files, 166 passed, 3 skipped for missing toolchains).