Skip to content

FIX invalid TP address startup to exit without panic - #311

Open
bansalayush247 wants to merge 1 commit into
dmnd-pool:masterfrom
bansalayush247:fix/validate-tp-address
Open

bansalayush247 wants to merge 1 commit into
dmnd-pool:masterfrom
bansalayush247:fix/validate-tp-address

Conversation

@bansalayush247

Copy link
Copy Markdown

Closes #212

Summary

  • Validate the Template Provider address during configuration loading.
  • Return configuration errors to the binary entry point and exit with status 1.
  • Remove panic paths from JD initialization and keep defensive validation.
  • Document the accepted ip:port format.

Checks

  • cargo test --lib tp_address
  • rustfmt --edition 2021 --check src/lib.rs src/main.rs
  • cargo clippy --lib --bin dmnd-client --all-features -- -D warnings
  • git diff --check limited to production files

Protected control tests and .github/workflows/mining-e2e.yml were not accessed.

Validate CLI, file, and environment values before proxy startup. Return configuration errors to the binary entry point, and keep JD initialization defensive if shared state becomes invalid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid --tp-address causes proxy to panic instead of failing gracefully

1 participant