Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions changes/unreleased/fix-register-rules-and-causes.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
### Fixed - the failure register files 31 more rows under the class that names them, and the four classes it had not investigated now carry their causes

- **What was wrong.** After the last release 30 failure rows still sat in `other` and 3 in `poll_deadline`, and four classes read "not investigated" (`failed_verification` 357 rows, `other`, `poll_deadline` 3, `stall_cold_load` 4). The rows in `other` were lane refusals and transport faults whose sentences or error classes no rule named. The 3 `poll_deadline` rows were not that class: each ends on a last poll error, so the node had stopped answering, not kept working past the allowance. One audio row was filed `failed_verification` though the audio was never judged (ffmpeg or ffprobe was missing).
- **Where each row now goes.** `no node that answered is called ...` (8 rows) is `node_busy`, the class the lane's own defer already files for new rows through its wire class. A dispatch whose connection could not be made (1), `N consecutive poll failures` (1), `rendered the job but fetching it failed` (1) and the 3 poll-deadline rows with a last poll error are `node_unreachable`. Error class `no_node_configured` (2) and the audio QA's missing-ffmpeg dead air (1) are `config`. `media convert: convert: in and out are required` (1) and error class `lint_errors` (1) are `bad_input`. `reasoning tier: low classify confidence ...` (3) is `abstention`. Compose's `check_failed` (5) is `failed_verification`, and the browse door's `blocked` (4) is `abstention`.
- **Two readings that are a choice.** `rendered the job but fetching it failed` is `node_unreachable` (the fetch dropped), with `infrastructure` the other reading because the render itself succeeded. Compose `check_failed` is `failed_verification` (the lane's own checks of the composition failed), with `bad_input` the other reading because the caller wrote the composition. Both are one-line rule changes.
- **The browse `blocked` rows.** `browse: blocked: the model or the loop reported no progress` (4 rows, one caller retrying within 4 minutes) is `abstention`: the loop ended with no usable answer. Why the page could not be driven is a separate question the row cannot answer. It is a prefix rule on the door's own sentence and not an error-class entry, because the word `blocked` means other things elsewhere; the prefix is reached because the error class is not in the table.
- **Left alone on purpose.** The 3 `generate_svg` rows with no reason, no reason code and no door cannot be traced. `other` is 3 rows.
- **How.** Each rule needs the writer's own fixed words. `media convert: convert: in and out are required` and `reasoning tier: low classify confidence ` are matched as whole sentences, not as the bare prefixes `media convert:` and `reasoning tier: `, because `media <op>: ` also wraps what ffmpeg reported and `reasoning tier: ` wraps other verifier wordings. Three new error classes are in `errClassCodes`; the dispatch, poll-failure and fetch sentences are in `legacyReasonCode`; the poll-deadline and audio rules are in `RefileStamped` and each needs both the old stamp and the writer's sentence, so no other row of those classes moves. The pin test `TestEveryCoreErrClassHasALedgerReasonCode` listed every error class but `no_node_configured`; it does now.
- **Causes.** `internal/ledger/rootcause.go` now holds the findings, with their counts and the day measured, and says where the evidence stops. `failed_verification` is a harness defect for the research lane's own checks: of 357 rows, 307 are those checks rejecting answers that were right or honest, of which 202 are established by comparing the digest to the page and 105 rest on the seat's own statement; 10 are seat misses, 4 a caller regex over-escaped, 1 a misfile, 35 undetermined. `poll_deadline` is an upstream node that stopped answering (why is not settled). `stall_cold_load` is one placement and filing defect on 2026-11-04: the placer put a long-context subtask on a seat that shares the pair's cards with the pool seat, and the monitor filed the wait behind the swap as a cold-load stall. `other` is a bundle of misfiled sentences, not one cause. The research acceptance fix ships in the same release: a digest that quotes its page is excused from the page-word tripwire, `research.Build` derives a `nonempty:` check over the caller's required fields in place of `min_items:<first required array>:1`, and an HTML page under 150 characters of text is refused before dispatch as a skipped source. An offline replay of the saved pages and answers (which reproduced every saved verdict, 356 fail and 4,622 pass) gives, of the 356 failed rows with a job id, 167 now pass, 16 are refused as pages with no content and 173 still fail (10 not research); of the 4,622 passes, 4,513 still pass, 109 are refused as pages with no content and none fails. Rows already written keep their class, so none of the register's 30-day counts changes from it. The follow-ups the entry still names (count the call's own siblings in `pairLong`, record the answer and the acceptance kind on the ledger row, stop stamping a poll deadline with a last poll error as `poll_deadline` at the writer) are not made here.
- **Docs.** The catalogue copy and the rule lists on `docs/systems/failure-register.md` match the code; `causes_not_investigated` is empty in the window.
- **Check.** The built binary and the installed one, both read-only on the real ledger, `ledger --failures --since 30`: 2,566 failure rows of 8,785 job rows in both, the sum over classes unchanged. `other` 30 to 3, `poll_deadline` 3 to 0, `node_busy` 704 to 712, `node_unreachable` 3 to 9, `failed_verification` 357 to 361, `abstention` 221 to 228, `config` 32 to 35, `bad_input` 2 to 4; every other class is unchanged. `causes_not_investigated` went from `failed_verification`, `other`, `poll_deadline`, `stall_cold_load` to none. Two further rows of the `no_node_configured` class are measurement runs the register leaves out.
Loading
Loading