Conversation
dm13450
commented
Aug 13, 2026
Owner
Author
There was a problem hiding this comment.
Any testing needs to be moved to test directory
| dpObj$clusterLabels <- rep(1L, nrow(dpObj$data)) | ||
| } | ||
|
|
||
| if (inherits(dpObj$mixingDistribution, c("normal_inverse_gamma", "normal"))) { |
Owner
Author
There was a problem hiding this comment.
Dispatch on the mdObj type, not these if statements
| storeSamples, thinning)) | ||
| } | ||
|
|
||
| if (inherits(dpObj$mixingDistribution, "normalFixedVariance")) { |
Owner
Author
There was a problem hiding this comment.
Dispatch on the mdObj type, not these if statements
| storeSamples, thinning)) | ||
| } | ||
|
|
||
| if (inherits(dpObj$mixingDistribution, "exponential")) { |
Owner
Author
There was a problem hiding this comment.
Dispatch on the mdObj type, not these if statements
| likelihoodValue <- numeric(2) | ||
| for (k in 1:2) { | ||
| state_params <- params[[states[candiateStates[k]]]] | ||
| if (inherits(mdobj, "normal")) { |
Owner
Author
There was a problem hiding this comment.
testing files should be in the test directory
Owner
Author
There was a problem hiding this comment.
Tests should be commented rather than this md file
Owner
Author
There was a problem hiding this comment.
Where is the standalone code to generate the plots now?
Owner
Author
There was a problem hiding this comment.
Edit README.Rmd not the .md
dm13450
commented
Aug 14, 2026
| alphaPost <- priorParameters[1] + length(x[i]) | ||
| betaPost <- priorParameters[2] + sum(x[i]) | ||
| pred[i] <- (gamma(alphaPost)/gamma(priorParameters[1])) * ((priorParameters[2] ^priorParameters[1])/(betaPost^alphaPost)) | ||
| # Corrected line: |
dm13450
commented
Aug 14, 2026
Owner
Author
There was a problem hiding this comment.
Follow the file structure
dm13450
commented
Aug 14, 2026
| @@ -1,10 +1,22 @@ | |||
| # dirichletprocess 0.4.2.9000 | |||
| # dirichletprocess 2.0.0 | |||
dm13450
commented
Aug 14, 2026
| Title: Build Dirichlet Process Objects for Bayesian Modelling | ||
| Version: 0.4.2.9000 | ||
| Title: Fit and Extend Dirichlet Process Mixture Models | ||
| Version: 2.1.0 |
dm13450
commented
Aug 14, 2026
| Kees Mulder [ctb] (<https://orcid.org/0000-0002-5387-3812>), | ||
| Giovanni Sighinolfi [ctb], | ||
| Filippo Fiocchi [ctb] | ||
| Maintainer: Gordon J. Ross <gordon.ross@ed.ac.uk> |
dm13450
commented
Aug 14, 2026
| person(given = "Dean", | ||
| family = "Markwick", | ||
| email = "dean.markwick@talk21.com", | ||
| role = "aut"), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.