Skip to content

chore: sync tests/tests/__init__.py w/ new test modules - #182

Open
jdlcdl wants to merge 1 commit into
diybitcoinhardware:masterfrom
jdlcdl:tests_init_file
Open

jdlcdl wants to merge 1 commit into
diybitcoinhardware:masterfrom
jdlcdl:tests_init_file

Conversation

@jdlcdl

@jdlcdl jdlcdl commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Adds imports of new test modules to tests/tests/init.py so that they are covered by micropython tests/run_tests.py

Also, sorted the list of imports to match ls tests for ease of maintenance.

new for all:

  • test_liquid
  • test_psetview

new for non-micropython:

  • test_psbtV2 (needs at least pytest)
  • test_psbt_verification (needs at least pytest)
  • test_liquid (needs zkp) moved up above for all platforms in 8a22884

on current branch "hardened":

  • pytest passes 433 tests, skips 22,
  • cd tests; micropython run_tests.py passes 128 tests.

@notTanveer notTanveer left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 893cb03

odudex
odudex previously approved these changes Nov 13, 2026
@odudex

odudex commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

ACK 1c57db6

@jdlcdl
jdlcdl changed the base branch from hardened to master November 13, 2026 19:06
@jdlcdl
jdlcdl dismissed odudex’s stale review November 13, 2026 19:06

The base branch was changed.

@jdlcdl

jdlcdl commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator Author

The contents of this PR were correct originally with ACKs from odudex and tanveer.

I made a mistake originally basing it to "hardened", so I have force-pushed the same contents as a pr branch on "master".

This pr at 8a22884 will be merged to "hardened" after pr181.

Thank you odudex and tanveer.

P.S. These tests fail against master because it is meant for an updated hardened branch that has many new test modules from PR #152

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants