Repository navigation
fix: replace dw_filter table on reload instead of appending rules - #1
Merged
Merged
Conversation
Loading the rendered ruleset twice added a second copy of every rule because nft -f merges into an existing table. Declare, delete, then redefine the table so the file atomically replaces only dw_filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Before: loading a rendered nftables file a second time added a second copy of every rule to
dw_filter, even though the header says the file replaces that table.After: reloading the file atomically replaces
dw_filterand leaves every other table alone.How: the ruleset now declares the table, deletes it, then defines it again, which is the standard nft idiom for atomic replacement. A test checks that order.