Repository navigation
Conversation
cert_exists() keeps only the first certificate from ca.cer. On the observed YR2 chain, this removes the cross-signed Root YR certificate and rejects a valid certificate, triggering the --force fallback. Supply the full issuer bundle with -untrusted and use the system trust store for trust anchors, preserving the intent of discourse#576.
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/the-too-many-certificates-error-ports-80-443-open-then-close/413078/10 |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cert_exists()can reject a valid Let's Encrypt certificate and trigger unnecessary forced issuance becauseopenssl x509 -in ca.cerkeeps only the first certificate from the issuer bundle.On actual RSA files containing
YR2and cross-signedRoot YR, the current check dropsRoot YRand fails:In the reinstall that exposed this, RSA issuance succeeded and was immediately followed by a forced RSA fallback, then two ECDSA attempts. The last three requests received rate-limit responses. The hostname had been used recently, so the quota could already have been partly consumed.
Preserve the intent of #576
#576 /
8e2cceechanged this check in 2021 to avoid the expired root in the old Let's Encrypt chain.The current hierarchy needs the cross-signed
Root YRto reachISRG Root X1on this host. Supplying the complete bundle with-untrustedpreserves the chain-building certificates and uses the system trust store for trust anchors.Validation
-untrusted, both normal issuance calls reportSkip, both existing chains are installed, andnginx -tpasses.CAfilereproduces the historical error types, while-untrustedsucceeds in both cases.Meta: https://meta.discourse.org/t/lets-encrypt-cert-exists-truncates-the-ca-chain-causing-forced-reissuance-and-rate-limit-failures/414167