Skip to content

refactor: alter classes to use 'with' for implementing Disposable interface #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gorniaky merged 1 commit into from
Oct 12, 2026
Merged

refactor: alter classes to use 'with' for implementing Disposable interface #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cli/context.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import "package:tint/tint.dart";
part "locale.dart";
part "paths.dart";

class CliContext implements Disposable {
class CliContext with Disposable {
static late final CliContext I;
static bool _instanced = false;

Expand Down
2 changes: 1 addition & 1 deletion lib/cli/printer/iprinter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import "package:discloud/cli/disposable.dart";
import "package:discloud/cli/printer/console_printer.dart";
import "package:discloud/cli/spin/ispin.dart";

abstract interface class const IPrinter() implements Disposable {
abstract interface class const IPrinter() with Disposable {
factory console({bool isDebug = true}) => ConsolePrinter(isDebug: isDebug);

ISpin spin({String? text, bool start = true});
Expand Down
2 changes: 1 addition & 1 deletion lib/services/discloud/api_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import "package:path/path.dart";
typedef VoidUploadProgressCallback = void Function(int processed);
typedef VoidUploadDoneCallback = FutureOr<void> Function();

class DiscloudApiClient implements Disposable {
class DiscloudApiClient with Disposable {
static const _apiScheme = "https";
static const _apiHost = "api.discloud.app";
static const _apiVersion = 2;
Expand Down
6 changes: 1 addition & 5 deletions lib/utils/progress.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,11 @@ import "package:discloud/extensions/num.dart";
import "package:discloud/utils/bytes.dart";
import "package:discloud/utils/formatters.dart";

enum UnitDirection {
enum UnitDirection(final String symbol) {
up("↑"),
down("↓"),
both("⇅");

new(this.symbol);

final String symbol;

@override
String toString() => symbol;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/utils/speed_monitor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ final class _SpeedSample extends LinkedListEntry<_SpeedSample> {
}

/// A utility class for monitoring processing speed over a sliding time window.
class SpeedMonitor implements Disposable {
class SpeedMonitor with Disposable {
static const double _zero = 0;

/// Creates a [SpeedMonitor]
Expand Down
Loading