Skip to content

refactor: replace ConsolePrinter and CLISpin instantiation with IPrin… #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gorniaky merged 1 commit into from
Oct 12, 2026
Merged

refactor: replace ConsolePrinter and CLISpin instantiation with IPrin… #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/cli/context.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import "dart:async";
import "dart:io";

import "package:discloud/cli/disposable.dart";
import "package:discloud/cli/printer/console_printer.dart";
import "package:discloud/cli/printer/iprinter.dart";
import "package:discloud/extensions/duration.dart";
import "package:discloud/extensions/list.dart";
Expand All @@ -29,7 +28,7 @@ class CliContext implements Disposable {
api: .new(),
arguments: arguments,
debug: debug,
printer: ConsolePrinter(isDebug: debug),
printer: IPrinter.console(isDebug: debug),
stopwatch: .new()..start(),
store: .json(_cliConfigFilePath),
subscriptions: [],
Expand Down
3 changes: 1 addition & 2 deletions lib/cli/printer/console_printer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import "dart:io";

import "package:discloud/cli/printer/iprinter.dart";
import "package:discloud/cli/spin/cli_spin.dart";
import "package:discloud/cli/spin/ispin.dart";

part "debug_console_printer.dart";
Expand All @@ -22,7 +21,7 @@ class ConsolePrinter implements IPrinter {

@override
ISpin spin({String? text, bool start = true, bool showDuration = true}) {
final spin = _spin ??= CLISpin(text: text, showDuration: showDuration);
final spin = _spin ??= ISpin.cli(text: text, showDuration: showDuration);
if (start) spin.start();
return spin;
}
Expand Down
4 changes: 3 additions & 1 deletion lib/cli/spin/cli_spin.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ part "timer_cli_spin.dart";
void _noop() {}

class CLISpin implements ISpin {
factory _timer({String? text}) => _TimerCLISpin._(text: text);

factory({String? text, bool showDuration = false}) =>
showDuration ? _TimerCLISpin._(text: text) : ._(.new(text: text));
showDuration ? ._timer(text: text) : ._(.new(text: text));

const new _(this._spin);

Expand Down
Loading