Repository navigation
fix(pcb): skip desktop launcher setup without xdg-mime - #1558
Merged
Merged
Conversation
Skip optional launcher updates on Linux when xdg-mime is unavailable, and avoid desktop registration warnings during fresh installs. Preserve desktop setup over SSH and report genuine update failures.
LK
approved these changes
Oct 22, 2026
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Match the shim's desktop capability check when xdg-mime is present but not executable. Exercise the full release installer against local artifacts, including skipped registration and genuine registration failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Running
pcb self updatein headless Linux containers such as Blaxel attempts to register the desktop URL handler. These images do not includexdg-mimeorupdate-desktop-database, producing warnings for an optional desktop component even though the CLI can update normally.Changes
xdg-mimeon PATH.Validation
xdg-mime, with downloads blocked, and verifies real toolchain failures still fail the command.cargo test -p pcb --locked: 9 tests passed.cargo clippy -p pcb --all-targets --locked -- -D warnings: passed.prek run cargo-fmt --files crates/pcb/src/main.rs crates/pcb/tests/self_update.rs install.sh: passed.bash -n install.sh: passed; installer branch checks covered Linux with/without xdg-mime, macOS, and genuine registration failures.Not yet released or tested in a live Blaxel sandbox.