Repository navigation
Hide WhatsApp channels in the new Updates list - #47
Merged
Merged
Conversation
WhatsApp now lists channels as ViewGroup children of updates_list, so the RelativeLayout path rule no longer matches and "Hide channels" does nothing. The new rule shares that comment so both sit behind one switch. The old rule stays: it is in the 0.9.1 snapshot and still covers older WhatsApp builds. Added to both flavours, which ship the same WhatsApp rules. Claude-Session: https://claude.ai/code/session_01GwnAB5CENNRMKt5vqGLKcS
This was referenced Oct 16, 2026
kasnder
added a commit
that referenced
this pull request
Oct 21, 2026
* Keep a row's state when a release adds a rule to it A row of sibling rules is on only while every rule in it is, and a new rule starts off. So when a release adds a rule to an existing row, as #46 and #47 do for LinkedIn and WhatsApp, the row turns off for every user who had it on, and their block silently stops. getRules() now gives a built-in rule that has no saved state the saved enabled flag and pause of a sibling in its row. Custom and navigation rules are left alone: custom rows are built by the user, and navigation rules have their own key space. Claude-Session: https://claude.ai/code/session_01GwnAB5CENNRMKt5vqGLKcS * Skip the bundled-row test where the flavour has no such row The gmwaylite flavour bundles no LinkedIn rules, so the row the test checks has a single rule there. The standard flavour still runs it. Claude-Session: https://claude.ai/code/session_01GwnAB5CENNRMKt5vqGLKcS --------- Co-authored-by: Claude <noreply@anthropic.com>
kasnder
marked this pull request as ready for review
October 21, 2026 08:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concern addressed: WhatsApp's "Hide channels" block no longer hides anything.
What changed and why: WhatsApp now lists channels as
android.view.ViewGroupchildren ofcom.whatsapp:id/updates_list, so theRelativeLayoutpath rule no longer matches. This adds a rule onupdates_listwithchildPath=android.view.ViewGroup[*], sharing the "Hide channels" category and comment so both rules sit behind one switch. The old rule stays because it is in the 0.9.1 snapshot and still covers older WhatsApp builds. Added tostandardandgmwaylite, which ship the same WhatsApp rules.As with #46, users who had "Hide channels" on will see the row switched off after updating (a merged row is on only when every rule in it is), and must re-enable it.
Evidence: The user reported the rule working on-device. Not verified by me: no Android SDK in this container, so unit tests were not run locally. Not checked whether
ViewGroup[*]underupdates_listalso covers the status rows above the channels, which would hide more than channels.Not in this PR: Carrying the old rule's enabled state over to the new sibling (same gap as #46).
https://claude.ai/code/session_01GwnAB5CENNRMKt5vqGLKcS
Generated by Claude Code