Repository navigation
Replace the picker's close button with an X and label expert entry points - #45
Merged
Merged
Conversation
…ints "Close picker" sat as a full-width button beside "Move to bottom", which read as one of the selection controls. An X at the top right of the sheet, next to the hint, is where people look to leave. The string stays as its content description for TalkBack. "Hide something new" and "Change opening screen" open the element picker, which needs some understanding of how apps are put together and can save a rule that taps or hides the wrong thing. Mark both as expert, matching the existing "Edit as text (expert)". The notification title keeps the plain "Change opening screen", so the buttons get their own string. Claude-Session: https://claude.ai/code/session_01F5t5sJbhPx8PhdLGfpkZsy
kasnder
marked this pull request as ready for review
October 16, 2026 10:23
"Move to top" did not say what would move. Now that the button has its own full-width row, the label can name the picker and the screen edge. Claude-Session: https://claude.ai/code/session_01F5t5sJbhPx8PhdLGfpkZsy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concern addressed: Make the element picker's own controls clearer, and label the buttons that open it as expert options.
What changed and why:
change_opening_screenas its title and keeps the plain wording, so the buttons use a newchange_opening_screen_expertstring.Evidence: CI unit tests pass. Not verified on a device: the cloud container had no Android SDK. The overlay change needs checking with the picker at the top and bottom of the screen, in light and dark mode.
Not in this PR: Nothing.
https://claude.ai/code/session_01F5t5sJbhPx8PhdLGfpkZsy