Repository navigation
Clarify app detail actions - #41
Merged
Merged
Conversation
Expose a separate opening-screen picker action and label the pause durations so the controls describe their effect. Keep each picker button scoped to its matching mode.
kasnder
force-pushed
the
codex/app-detail-actions
branch
from
September 25, 2026 09:29
b33b13d to
e5cd2e8
Compare
Carry the requested picker mode through the notification flow so the new Custom rules action selects a destination. Align the pause heading with section labels and use the existing text-button style for the secondary action.
The picker controls are intentionally hidden in gmwaylite by resource override. Verify both hidden controls there while retaining the notification routing assertions in standard.
Use a white pill with a navy outline and sentence-case text on both entry screens so the secondary action remains visible against the warm background.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concern addressed: Opening-screen selection is hidden behind the blocking picker in app detail and missing from Custom rules; the pause action and secondary picker control are visually unclear.
What changed and why: Added a separate “Change opening screen” action in app detail and Custom rules. The Custom rules action carries navigation mode through its notification so it can select a destination in another app; the hide action remains scoped to blocking. Matched the pause heading to existing section labels and made the secondary action a white, navy-outlined pill on both screens.
Evidence:
./gradlew testpassed across both flavours../gradlew assembleStandardDebug lintStandardDebugandgit diff --checkpassed. The updated layouts were installed and visually checked on a Pixel 8. The final PR CI run passed.Not in this PR: Android SDK CI setup is in PR #42, on which this PR is stacked. Picker interaction has not been exercised on-device.