build: remove gsl as the dependency in the build#27
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 81.63% 81.63%
=======================================
Files 3 3
Lines 49 49
=======================================
Hits 40 40
Misses 9 9 🚀 New features to boost your workflow:
|
sbillinge
reviewed
May 11, 2026
| """ | ||
|
|
||
|
|
||
| from pkgutil import extend_path |
Contributor
There was a problem hiding this comment.
I think we want to avoid this. We don't do it for any of our other packages that all build correctly, so I think this is not the right fix. Let's at least revert this and merge the gsl fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review. This is specific for the build on
conda-forgeasgslis not needed directly by this package. When we list this as a requirement inconda, it could not understand why we need this and thepip checkwould fail.In addition, we need the namespace extension to avoid the conflict as seen in the
conda-forgebuild failure.