Skip to content

chore: migrate the refinement functionality#3

Merged
sbillinge merged 8 commits into
diffpy:mainfrom
ycexiao:refine-batch
May 12, 2026
Merged

chore: migrate the refinement functionality#3
sbillinge merged 8 commits into
diffpy:mainfrom
ycexiao:refine-batch

Conversation

@ycexiao
Copy link
Copy Markdown

@ycexiao ycexiao commented May 11, 2026

What problem does this PR address?

Migrate the refinement functionality

What should the reviewer(s) do?

Comment thread pyproject.toml

[project.scripts]
diffpy-batchpdfsuite = "diffpy.batchpdfsuite.app:main"
bpdfsuite = "diffpy.batchpdfsuite.batchpdfsuite_app:main"
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use bpdfsuite as the command.

@@ -1,33 +1,67 @@
import argparse
#!/usr/bin/env python
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reused most of the code of getxguiapp.py from diffpy.xpdfsuite in here, so I am not sure what to do about this license.

@ycexiao
Copy link
Copy Markdown
Author

ycexiao commented May 11, 2026

The app is now
image

TODOs:

  • choose icons for splash, settings, log, and help
  • determine options for settings
  • provide quick tutorial for help

@ycexiao
Copy link
Copy Markdown
Author

ycexiao commented May 12, 2026

Screenshot 2026-05-12 at 12 14 11 PM

@ycexiao ycexiao marked this pull request as ready for review May 12, 2026 16:48
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ycexiao
Copy link
Copy Markdown
Author

ycexiao commented May 12, 2026

@sbillinge, this PR is ready to be merged. I will create other issues for adding quick tutorial and setting's options.

@sbillinge sbillinge merged commit 0b25216 into diffpy:main May 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants