Repository navigation
fix: keep status page charts legible on narrow screens - #6
Merged
Merged
Conversation
On a 280px-wide view the price plot shrank to 98px: the x labels ran into each other, and the hover read-out ran off the chart. Each chart now sizes its chrome by its own width (container queries). Below 480px the end labels give their room to the plot; the legend and read-out still name every line. Below 300px every other x label is hidden, leaving 00:00, 12:00 and 24:00. The read-out sits on whichever side of the crosshair fits, never leaves the chart, and truncates series names rather than values. Checked at 280, 320 and 375px.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live status page in a 280px-wide view: the price plot shrank to 98px, so the x labels overlapped and the hover read-out ran off the chart. Small phones or larger text settings hit the same thing.
I checked it with headless Chrome at 280, 320 and 375px against the live data. Tests and lint pass; a new assertion covers the minor-tick markup.
Only
src/voltcast/page.pychanges, so on merge the status workflow republishes the page. The deploy workflow also runs, but it only updates the Lambda's code hash.