fix(cli): download ic-admin from GitHub releases#2039
Draft
r-birkner wants to merge 3 commits into
Draft
Conversation
…dfinity.systems
The download.dfinity.systems host no longer serves ic-admin binaries.
Switch to GitHub releases (dfinity/ic), resolving the release tag from
the commit hash via the GitHub matching-refs API. Update asset naming
to match new conventions (ic-admin-{arch}-{os}.gz) and add ARM support.
Update fallback version to one that has a GitHub release.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rls was removed from Rust in newer versions. rust-analyzer is the current replacement. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
download.dfinity.systemsno longer serves ic-admin binaries; switch to GitHub Releases ondfinity/icfind_github_release_tag_for_commitwhich resolves a commit SHA to a release tag by querying the GitHubmatching-refsAPI (searches from current year back to 2024, with pagination)ic-admin-{arm64,x86_64}-{darwin,linux}.gzFALLBACK_IC_ADMIN_VERSIONtob95f4a32b41798de115aac9298b51dd1662f1da5(release-2026-06-04_04-52-base), since the old fallback has no GitHub releaseTest plan
dreon a macOS (Apple Silicon) machine and verify ic-admin is downloaded from GitHubdreon an x86_64 Linux machine and verify ic-admin is downloaded from GitHub🤖 Generated with Claude Code