refactor: FsstEncodingEncoder reuses PTypeIO.set instead of reimplementing it - #274
Merged
Conversation
…nting it The private writeUnsigned helper duplicated core.io.PTypeIO.set, the canonical narrow-ptype write helper (MethodHandle-based, byte-offset addressed, already used by every other encoder). Its default branch throwing VortexException was dead: narrowestUnsigned only ever returns U8/U16/U32, all of which PTypeIO.set handles with identical little-endian layout and truncation-on-narrowing. Deleted writeUnsigned and the now-unused VortexException import; the two call sites now pass idx * ptype.byteSize() as the byte offset, matching the established PTypeIO.set idiom. Also close a round-trip coverage gap this refactor's own risk surface exposed: every stringArrays() case kept uncompLenPType/codesOffPType in the U8 tier, so the U16 length/offset write path was only checked via metadata assertions, never a full decode. Add a 301-row u16-tier case (one 300-byte row plus 300 single-char rows) that goes through encode_thenDecode_roundtripsAllStrings, so the U16 buffer bytes are read back and verified per row -- a wrong U16 stride now corrupts many rows and fails the assertion. A metadata test pins that both ptypes escalate. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dfa1
force-pushed
the
refactor/fsst-reuse-ptypeio
branch
from
July 17, 2026 13:17
b92abe1 to
ea01579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FsstEncodingEncoder.writeUnsignedduplicatedcore.io.PTypeIO.set, the canonical narrow-ptype write helper already used by every other encoder (RleEncodingEncoder,BitpackedEncodingEncoder,SparseEncodingEncoder, etc.) — flagged in review of Raincloud triage round 268 269 #271.writeUnsigned; both call sites now passidx * ptype.byteSize()as the byte offset toPTypeIO.setdirectly. Itsdefault -> throwbranch was dead code (PType.narrowestUnsignedonly ever returns U8/U16/U32).Test plan
./mvnw test -pl writer -am -Dtest=FsstEncodingEncoderTest— passed./mvnw test -pl writer -am— full writer module, 1702 tests, 0 failures🤖 Generated with Claude Code