fix(api): parse compound QEMU agent settings - #148
Open
oechsler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this while configuring pvetui for my homelab.
My Proxmox VMs are NixOS guests. The QEMU Guest Agent is enabled in the VM configuration and the service is enabled in NixOS with
services.qemuGuest.enable = true. The agent is working:qm agent <VMID> pingsucceeds andqm agent <VMID> network-get-interfacesreturns the correct guest IP address.However, pvetui showed the Guest Agent as disabled and did not display any IP address for these guests.
The Proxmox API returns the agent setting in this form:
In
GetVmStatus, pvetui compared the complete string only with"1"and"true". As a result, it treated the agent as disabled and never queried the guest-agent network interfaces.This change reuses the existing
parseQEMUAgentEnabledhelper, which already handles compound Proxmox values correctly in the VM configuration path.I tested this with my actual Proxmox/NixOS setup and with:
go test ./pkg/apigo test ./...