Repository navigation
chore(deps): clear the Dependabot backlog and test puppeteer in PR CI - #28
Merged
Merged
Conversation
- puppeteer 24 -> 25.18.1: npm audit goes from 10 high to 0 (basic-ftp, extract-zip and zod were only fixable on 25). The script only calls launch/newPage/setContent/pdf/close, so v25's async executablePath and ESM-only changes don't touch it. Local build renders the same 2 pages. - actions/checkout and setup-node to v7, sticky-pull-request-comment 3.0.5 - the resume workflow now builds (without committing) on PRs that touch dependencies, so puppeteer bumps are tested before they merge - Renovate: automerge stable non-major and lockfile updates once checks pass, pin action digests
Contributor
Lighthouse CI ResultsLighthouse (desktop)
All pages pass thresholds (Perf >= 95, others = 100). Lighthouse (mobile)
All pages pass thresholds (Perf >= 95, others = 100).Median of 3 runs | Thresholds: Perf >= 95, A11y/BP/SEO = 100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
18 Dependabot alerts were open (8 high) and 10 Renovate/Dependabot PRs had been sitting since May. All of them came from the puppeteer toolchain that builds the resume PDF. None of it ships to koriel.kr.
Updates
npm auditgoes from 10 high to 0. basic-ftp, extract-zip and zod could only be fixed on 25. v25's breaking changes (Node 22+, ESM only, asyncexecutablePath/defaultArgs) don't touchbuild-resume.mjs, which only callslaunch,newPage,setContent,pdfandclose. A local build renders the same two pages with the same text. I kept the committed PDF because the local one used macOS fonts.CI
Build Resume PDFnow also runs on PRs that touchpackage.json,package-lock.json,resume.jsonor the build script. It builds and checks the PDF exists, and skips the commit step. Before this, the PR checks never ran puppeteer.Renovate
platformAutomergeis off because main has no required checks.Supersedes #17, #19, #20, #21, #22, #23, #24, #25 and #26. Node 26 (#27) is left for review.