Skip to content

chore(deps): clear the Dependabot backlog and test puppeteer in PR CI - #28

Merged
devkoriel merged 1 commit into
mainfrom
chore/deps-catch-up-2026-11
Nov 18, 2026
Merged

devkoriel merged 1 commit into
mainfrom
chore/deps-catch-up-2026-11

Conversation

@devkoriel

Copy link
Copy Markdown
Owner

18 Dependabot alerts were open (8 high) and 10 Renovate/Dependabot PRs had been sitting since May. All of them came from the puppeteer toolchain that builds the resume PDF. None of it ships to koriel.kr.

Updates

  • puppeteer 24.37 -> 25.18.1. npm audit goes from 10 high to 0. basic-ftp, extract-zip and zod could only be fixed on 25. v25's breaking changes (Node 22+, ESM only, async executablePath/defaultArgs) don't touch build-resume.mjs, which only calls launch, newPage, setContent, pdf and close. A local build renders the same two pages with the same text. I kept the committed PDF because the local one used macOS fonts.
  • actions/checkout and setup-node to v7, sticky-pull-request-comment 3.0.5

CI

  • Build Resume PDF now also runs on PRs that touch package.json, package-lock.json, resume.json or the build script. It builds and checks the PDF exists, and skips the commit step. Before this, the PR checks never ran puppeteer.

Renovate

  • automerge stable non-major and weekly lockfile updates once checks pass. platformAutomerge is off because main has no required checks.
  • pin action digests

Supersedes #17, #19, #20, #21, #22, #23, #24, #25 and #26. Node 26 (#27) is left for review.

- puppeteer 24 -> 25.18.1: npm audit goes from 10 high to 0 (basic-ftp,
  extract-zip and zod were only fixable on 25). The script only calls
  launch/newPage/setContent/pdf/close, so v25's async executablePath and
  ESM-only changes don't touch it. Local build renders the same 2 pages.
- actions/checkout and setup-node to v7, sticky-pull-request-comment 3.0.5
- the resume workflow now builds (without committing) on PRs that touch
  dependencies, so puppeteer bumps are tested before they merge
- Renovate: automerge stable non-major and lockfile updates once checks
  pass, pin action digests
@github-actions

Copy link
Copy Markdown
Contributor

Lighthouse CI Results

Lighthouse (desktop)

Page Perf A11y BP SEO
/ 100 100 100 100
/404.html 100 100 100 100

All pages pass thresholds (Perf >= 95, others = 100).

Lighthouse (mobile)

Page Perf A11y BP SEO
/ 100 100 100 100
/404.html 100 100 100 100

All pages pass thresholds (Perf >= 95, others = 100).

Median of 3 runs | Thresholds: Perf >= 95, A11y/BP/SEO = 100

@devkoriel
devkoriel merged commit dba3ccb into main Nov 18, 2026
5 checks passed
@devkoriel
devkoriel deleted the chore/deps-catch-up-2026-11 branch November 18, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant