Repository navigation
fix(operator): harden DGDR run publication - #2
Merged
devivasudevan merged 2 commits intoOct 23, 2026
Merged
devivasudevan merged 2 commits into
devivasudevan merged 2 commits into
Conversation
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
|
👋 Hi sttts! Thank you for contributing to devivasudevan/dynamo. Just a reminder: The 🚀 |
sttts
commented
Oct 23, 2026
sttts
left a comment
Author
There was a problem hiding this comment.
The inline findings cover the remaining ownership atomicity, cache visibility, and update-watch test gaps in this on-top PR.
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
devivasudevan
merged commit Oct 23, 2026
5c9eeb3
into
devivasudevan:dgdr-run-publisher-clean2
24 of 26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden the DGDR run publisher introduced by ai-dynamo#15894 around ownership, event handling, and terminal outcomes.
messageanderror, fail a nominally successful run when no Candidate was materialized, and write the bounded UTF-8 failure detail to/dev/termination-logfor the future Run controller.This changes reconciliation behavior only; it does not change the DGDR, Run, or Candidate API schemas.
Validation
go test -tags=clustertest ./internal/dgdrrunpublisher ./cmd/dgdr-run-publisherKUBEBUILDER_ASSETS="$PWD/bin/k8s/1.30.0-darwin-arm64" go test ./internal/dgdrrunpublisher ./cmd/dgdr-run-publishergo test -race -tags=clustertest ./internal/dgdrrunpublisher ./cmd/dgdr-run-publishergo vet ./internal/dgdrrunpublisher ./cmd/dgdr-run-publishergit diff --checkEnvtest covers a foreign object already occupying the deterministic name, a foreign create that wins the name race, delete/recreate between the ownership read and SSA, repair and cleanup after label drift, and Candidate status repair caused by an update event after the controller has converged and become quiet.
Tracking
This is an on-top fix for review findings on ai-dynamo#15894. No matching issue is linked from that PR or was found in the repository issue search.